Skip to content

Detect stale outputs in Laplacian pyramid/reconstruct tests (#37) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiritigowda merged 3 commits into from
Jul 14, 2026
+99 −2
Merged

Detect stale outputs in Laplacian pyramid/reconstruct tests (#37) #40

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
229d218
Fix Laplacian pyramid/reconstruct stale-output coverage (#37)
kiritigowda Jul 13, 2026
be8bb98
Address Copilot review: re-run the same graph and guard U8 (#37)
kiritigowda Jul 13, 2026
7d0c996
Merge branch 'openvx_1.3.2' into fix/laplacianpyramid-stale-output
kiritigowda Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions test_conformance/test_laplacianpyramid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,24 @@ TEST_WITH_ARG(LaplacianPyramid, testGraphProcessing, Arg, LAPLACIAN_PYRAMID_PARA
own_laplacian_pyramid_reference(context, border, src, ref_pyr, ref_dst);
own_laplacian_pyramid_openvx(context, border, src, tst_pyr, tst_dst);

/* Issue #37: modify the input and re-run the graph a second time to detect
stale-output bugs. Rebuild the reference with the modified input so the
comparison is fair for implementations that correctly recompute. */
{
CT_Image modified = ct_allocate_image(input->width, input->height, input->format);
Comment thread
kiritigowda marked this conversation as resolved.
vx_image mod_src = 0;
vx_uint32 x, y;

for (y = 0; y < input->height; y++)
for (x = 0; x < input->width; x++)
modified->data.y[y * modified->stride + x] = ~input->data.y[y * input->stride + x];
Comment thread
kiritigowda marked this conversation as resolved.

ASSERT_VX_OBJECT(mod_src = ct_image_to_vx_image(modified, context), VX_TYPE_IMAGE);
own_laplacian_pyramid_reference(context, border, mod_src, ref_pyr, ref_dst);
own_laplacian_pyramid_openvx(context, border, mod_src, tst_pyr, tst_dst);
Comment thread
kiritigowda marked this conversation as resolved.
Outdated
VX_CALL(vxReleaseImage(&mod_src));
}

{
CT_Image ct_ref_dst = 0;
CT_Image ct_tst_dst = 0;
Expand Down Expand Up @@ -1119,6 +1137,25 @@ TEST_WITH_ARG(LaplacianReconstruct, testGraphProcessing, Arg, LAPLACIAN_RECONSTR
own_laplacian_reconstruct_reference(context, build_border, ref_pyr, ref_lowest_res, ref_dst);
own_laplacian_reconstruct_openvx(context, build_border, ref_pyr, ref_lowest_res, tst_dst);

/* Issue #37: modify the input and re-run the graph a second time to detect
stale-output bugs. Rebuild the reference pyramid and reconstruction with
the modified input so the comparison is fair. */
{
CT_Image modified = ct_allocate_image(input->width, input->height, input->format);
Comment thread
kiritigowda marked this conversation as resolved.
vx_image mod_src = 0;
vx_uint32 x, y;

for (y = 0; y < input->height; y++)
for (x = 0; x < input->width; x++)
modified->data.y[y * modified->stride + x] = ~input->data.y[y * input->stride + x];
Comment thread
kiritigowda marked this conversation as resolved.

ASSERT_VX_OBJECT(mod_src = ct_image_to_vx_image(modified, context), VX_TYPE_IMAGE);
own_laplacian_pyramid_reference(context, build_border, mod_src, ref_pyr, ref_lowest_res);
own_laplacian_reconstruct_reference(context, build_border, ref_pyr, ref_lowest_res, ref_dst);
own_laplacian_reconstruct_openvx(context, build_border, ref_pyr, ref_lowest_res, tst_dst);
VX_CALL(vxReleaseImage(&mod_src));
}

{
CT_Image ct_ref_dst = 0;
CT_Image ct_tst_dst = 0;
Expand Down