Don't install buck as root

Change-Id: I5b7ab1e16b5295947f625a6ec405534067e0b85e
KevinMFong · Dec 4, 2015 · 8fa28b2 · 8fa28b2
1 parent 54a06a5
commit 8fa28b2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -14,9 +14,9 @@ Role Variables
 | Name                   | Default                           | Description                                 |
 |------------------------|-----------------------------------|---------------------------------------------|
 | buck_repository_url    | https://github.com/facebook/buck  | URL of buck git repository                  |
-| buck_installation_dir  | /opt/buck                         | Source installation directory               |
+| buck_installation_dir  | ~/buck                            | Source installation directory               |
 | buck_revision          | master                            | Revision of buck to check out               |
-| buck_bin_dir           | /usr/local/bin                    | Directory in which to symlink the binaries  |
+| buck_bin_dir           | ~/bin                             | Directory in which to symlink the binaries  |
 
 Example Playbook
 ----------------

diff --git a/defaults/main.yml b/defaults/main.yml
@@ -2,6 +2,6 @@
 # default vars file for Buck
 
 buck_repository_url: https://github.com/facebook/buck
-buck_installation_dir: /opt/buck
+buck_installation_dir: ~/buck
 buck_revision: master
-buck_bin_dir: /usr/local/bin/
+buck_bin_dir: ~/bin
diff --git a/tasks/main.yml b/tasks/main.yml
@@ -4,9 +4,6 @@
 - name: Create Buck installation directory
   file: >
     path={{ buck_installation_dir }}
-    owner=root
-    group=root
-    mode=0755
     state=directory
   tags: buck
 
@@ -23,21 +20,23 @@
     chdir={{ buck_installation_dir }}
   tags: buck
 
+- name: Create Buck bin directory
+  file: >
+    path={{ buck_bin_dir }}
+    state=directory
+  tags: buck
+
 - name: Create buck symlink
   file: >
     src={{ buck_installation_dir }}/bin/buck
     dest={{ buck_bin_dir }}/buck
-    owner=root
-    group=root
     state=link
   tags: buck
 
 - name: Create buckd symlink
   file: >
     src={{ buck_installation_dir }}/bin/buckd
     dest={{ buck_bin_dir }}/buckd
-    owner=root
-    group=root
     state=link
   tags: buck