Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a detailed guide for bulk Excel file uploads to better inform users of file requirements and template usage.
- Revised file upload policy display with clear instructions
- Added links for template download with styled typography and layout improvements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/PrivatePropertyListPage/PropertyAddButtonList/BulkUploadModal.tsx | Updated upload policy display with improved typography and link for template download using the property-specific template URL. |
| src/pages/CustomerListPage/CustomerAddButtonList/CustomerBulkUploadModal.tsx | Enhanced upload guidelines for customer data; includes styled instructions and a link for the template download, though one link appears to reference a property template URL. |
| <Typography variant="body2" color="text.secondary" sx={{ mb: 1 }}> | ||
| 엑셀의 열 순서가 변경되면 업로드가 실패할 수 있으니,{" "} | ||
| <Link | ||
| to={import.meta.env.VITE_PROPERTY_EXCEL_TEMPLATE_URL} |
There was a problem hiding this comment.
The first template link in the customer upload modal uses 'VITE_PROPERTY_EXCEL_TEMPLATE_URL', which is inconsistent with the customer-specific template URL used later ('VITE_CUSTOMER_EXCEL_TEMPLATE_URL'). Please confirm if this is intentional or update it to ensure consistency.
Suggested change
| to={import.meta.env.VITE_PROPERTY_EXCEL_TEMPLATE_URL} | |
| to={import.meta.env.VITE_CUSTOMER_EXCEL_TEMPLATE_URL} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
📸 스크린샷 (선택)
💬리뷰 요구사항(선택)