feat: 대시보드 - 통계 부분 클릭시 모달로 보여주도록 수정#156
Merged
julia98percent merged 7 commits intodevfrom May 14, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dashboard page to show detailed statistics by introducing modal dialogs for recent customers, recent contracts, ongoing contracts, and completed contracts. Key changes include:
- Adding four new modal components for different contract and customer data views.
- Updating DashboardPage state management and API calls to fetch and paginate contract data.
- Integrating loading indicators and UI interactions (click handlers) across the dashboard cards.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/DashboardPage/RecentCustomersModal.tsx | New modal UI for displaying recent survey responses. |
| src/pages/DashboardPage/RecentContractsModal.tsx | New modal UI for recent contract details with pagination. |
| src/pages/DashboardPage/OngoingContractsModal.tsx | New modal UI for ongoing contracts with loading and navigation. |
| src/pages/DashboardPage/CompletedContractsModal.tsx | New modal UI for completed contracts with pagination. |
| src/pages/DashboardPage/DashboardPage.tsx | Updated dashboard card interactions and API calls for modals. |
Comments suppressed due to low confidence (2)
src/pages/DashboardPage/DashboardPage.tsx:843
- The variable 'ongoingContracts' is not defined. It appears you intended to check the length of the ongoing contracts list, so consider changing it to 'ongoingContractsList.length > 0'.
onClick={() => ongoingContracts > 0 && setOngoingContractsOpen(true)}
src/pages/DashboardPage/RecentContractsModal.tsx:41
- The constant 'CONTRACT_STATUS_TYPES' is declared in multiple files. To reduce duplication and potential inconsistencies, consider extracting it into a shared module.
const CONTRACT_STATUS_TYPES = [ ... ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#141
📝작업 내용
📸 스크린샷 (선택)
💬리뷰 요구사항(선택)