Skip to content

feat: 대시보드 - 통계 부분 클릭시 모달로 보여주도록 수정#156

Merged
julia98percent merged 7 commits intodevfrom
feature/141
May 14, 2025
Merged

feat: 대시보드 - 통계 부분 클릭시 모달로 보여주도록 수정#156
julia98percent merged 7 commits intodevfrom
feature/141

Conversation

@julia98percent
Copy link
Collaborator

#️⃣연관된 이슈

#141

📝작업 내용

이번 PR에서 작업한 내용을 간단하게 작성해주세요. 어떻게보다 무엇을 왜 수정했는지 설명해주세요. (이미지 첨부 가능)

📸 스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@julia98percent julia98percent requested a review from Copilot May 14, 2025 12:42
@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kernel360-kdev-4-zipline-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 0:42am

@julia98percent julia98percent merged commit eb9c3cf into dev May 14, 2025
3 checks passed
@julia98percent julia98percent deleted the feature/141 branch May 14, 2025 12:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dashboard page to show detailed statistics by introducing modal dialogs for recent customers, recent contracts, ongoing contracts, and completed contracts. Key changes include:

  • Adding four new modal components for different contract and customer data views.
  • Updating DashboardPage state management and API calls to fetch and paginate contract data.
  • Integrating loading indicators and UI interactions (click handlers) across the dashboard cards.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/pages/DashboardPage/RecentCustomersModal.tsx New modal UI for displaying recent survey responses.
src/pages/DashboardPage/RecentContractsModal.tsx New modal UI for recent contract details with pagination.
src/pages/DashboardPage/OngoingContractsModal.tsx New modal UI for ongoing contracts with loading and navigation.
src/pages/DashboardPage/CompletedContractsModal.tsx New modal UI for completed contracts with pagination.
src/pages/DashboardPage/DashboardPage.tsx Updated dashboard card interactions and API calls for modals.
Comments suppressed due to low confidence (2)

src/pages/DashboardPage/DashboardPage.tsx:843

  • The variable 'ongoingContracts' is not defined. It appears you intended to check the length of the ongoing contracts list, so consider changing it to 'ongoingContractsList.length > 0'.
onClick={() => ongoingContracts > 0 && setOngoingContractsOpen(true)}

src/pages/DashboardPage/RecentContractsModal.tsx:41

  • The constant 'CONTRACT_STATUS_TYPES' is declared in multiple files. To reduce duplication and potential inconsistencies, consider extracting it into a shared module.
const CONTRACT_STATUS_TYPES = [ ... ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants