Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a back button to the header component for improved navigation.
- Introduces an IconButton with an ArrowBackIcon that triggers navigation to the previous page.
- Updates the header layout to accommodate the new back button.
Comments suppressed due to low confidence (1)
src/components/PageHeader/PageHeader.tsx:59
- Add an aria-label to the IconButton (e.g., aria-label="Go back") to enhance accessibility.
<IconButton onClick={() => navigate(-1)} sx={{
Comment on lines
+58
to
+70
| { | ||
| <IconButton | ||
| onClick={() => navigate(-1)} | ||
| sx={{ | ||
| color: "#164F9E", | ||
| "&:hover": { | ||
| backgroundColor: "rgba(22, 79, 158, 0.04)", | ||
| }, | ||
| }} | ||
| > | ||
| <ArrowBackIcon /> | ||
| </IconButton> | ||
| } |
There was a problem hiding this comment.
[nitpick] Remove the unnecessary JSX curly braces that wrap the IconButton since the component is always rendered.
Suggested change
| { | |
| <IconButton | |
| onClick={() => navigate(-1)} | |
| sx={{ | |
| color: "#164F9E", | |
| "&:hover": { | |
| backgroundColor: "rgba(22, 79, 158, 0.04)", | |
| }, | |
| }} | |
| > | |
| <ArrowBackIcon /> | |
| </IconButton> | |
| } | |
| <IconButton | |
| onClick={() => navigate(-1)} | |
| sx={{ | |
| color: "#164F9E", | |
| "&:hover": { | |
| backgroundColor: "rgba(22, 79, 158, 0.04)", | |
| }, | |
| }} | |
| > | |
| <ArrowBackIcon /> | |
| </IconButton> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#148
📝작업 내용
📸 스크린샷 (선택)
💬리뷰 요구사항(선택)