Skip to content

WEB - (준)실시간 경로#340

Merged
devJeenee merged 15 commits intodevelopfrom
feat/real-path
May 13, 2025
Merged

WEB - (준)실시간 경로#340
devJeenee merged 15 commits intodevelopfrom
feat/real-path

Conversation

@ji-won-2
Copy link
Collaborator

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

(준)실시간 경로

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@ji-won-2 ji-won-2 changed the base branch from main to develop May 13, 2025 03:42
@Service
public class EventEmitterService {
private final Map<String, SseEmitter> emitters = new ConcurrentHashMap<>();
private static final Map<String, SseEmitter> emitters = new ConcurrentHashMap<>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static으로 두신 이유가 있나요?

private final Map<String, SseEmitter> emitters = new ConcurrentHashMap<>();
private static final Map<String, SseEmitter> emitters = new ConcurrentHashMap<>();

public static Map<String, SseEmitter> getTest() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용하지 않는 함수같은데 지우는게 좋을 것 같습니다

import kernel360.trackyweb.realtime.infrastructure.repository.GpsHistoryRepositoryCustom;

@Component
//@RequiredArgsConstructor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지우는게 좋을 것 같습니다

Copy link
Collaborator

@Tojaman Tojaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘하셨네요 ! 고생하셨습니다.

@devJeenee devJeenee merged commit cbfc8a8 into develop May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants