Conversation
kimchijinju
approved these changes
May 8, 2025
| public ApiResponse<MonthlyStatisticResponse> getMonthlyStatistic(String bizUuid, YearMonth date, | ||
| YearMonth targetDate) { | ||
|
|
||
| if (targetDate == null) { |
Collaborator
There was a problem hiding this comment.
targetDate가 null인 경우는 언제가 있나요?
그리고 - 1년 + 1월은 어떤 의도를 가진 코드인가요?
Collaborator
Author
There was a problem hiding this comment.
targetDate가 null인 경우는 언제가 있나요? 그리고 - 1년 + 1월은 어떤 의도를 가진 코드인가요?
date는 기준이 되는 월이고 targetDate는 그래프를 어디까지 보여줄지 결정하는 변수였는데 고정 12개월로 보여주는걸로 되어서 지금은 사용하지 않는 변수입니다
-1년 +1월은 -11개월보다 작년까지의 데이터를 보여준다는 뜻이 잘 드러나는 것 같아서 쓴건데 이것도 좀 이상하긴 하네요...
둘 다 수정해서 다시 푸시하겠습니다
devJeenee
approved these changes
May 8, 2025
jun950829
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
월간, 일간 통계 그래프 데이터 조회 메서드 추가
월간, 일간 통계 API 응답에 그래프 데이터 추가
스크린샷 (선택)