-
Notifications
You must be signed in to change notification settings - Fork 4
2024.07.31 1차 회고 이후 코드리뷰 관련하여 확인할 만한 내용 추가 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YunNote
wants to merge
3
commits into
code-review
Choose a base branch
from
feature/review-20240731
base: code-review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−0
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ public class ScriptController { | |
| */ | ||
| @GetMapping("/{userId}") | ||
| public ResponseEntity<List<ScriptEntity>> getScriptAll(@PathVariable Long userId){ | ||
|
|
||
| return scriptService.getScriptList(userId); | ||
| } | ||
|
|
||
|
|
@@ -31,6 +32,7 @@ public ResponseEntity<List<ScriptEntity>> getScriptAll(@PathVariable Long userId | |
| */ | ||
| @PostMapping("") | ||
| public ResponseEntity<ScriptEntity> addScript(@RequestBody ScriptEntity scriptEntity) { | ||
|
|
||
| return scriptService.addScript(scriptEntity); | ||
| } | ||
|
|
||
|
|
@@ -42,6 +44,7 @@ public ResponseEntity<ScriptEntity> addScript(@RequestBody ScriptEntity scriptEn | |
| @PutMapping("") | ||
| public ResponseEntity<ScriptEntity> updateScript( | ||
| @RequestBody ScriptEntity scriptEntity) { | ||
|
|
||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Entity를 Request 와 Response 로 쓰고 있는 부분에 대해서 각각의 Request, Response 파일로 변경도 해보시고, inner Class 를 사용하여 하는 방식으로 도 고민해봇기면 좋을것 같습니다 ! |
||
| return scriptService.updateScript(scriptEntity); | ||
| } // 업데이트 시 내용 날아갈 수 있어 수정 필요 | ||
|
|
||
|
|
@@ -53,6 +56,7 @@ public ResponseEntity<ScriptEntity> updateScript( | |
| @DeleteMapping("/{scriptId}") | ||
| public ResponseEntity<ScriptEntity> deleteScript(@PathVariable Long scriptId) { | ||
|
|
||
|
|
||
| scriptService.deleteScriptById(scriptId); | ||
| return ResponseEntity.ok().build(); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entity를 직접적으로 반환하는 부분에 대해서 Request, Response class 로 변경하는것에 대해서 고민해보시면 좋을것 같습니다