Skip to content

[Refactor] 코드 리뷰 - 기본 Executor 전략으로 변경 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kimminkyeu wants to merge 1 commit into from
Closed

[Refactor] 코드 리뷰 - 기본 Executor 전략으로 변경 #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions backend/src/main/java/org/example/image/AsyncImageAnalyzePipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ public class AsyncImageAnalyzePipeline {
* baeldung.com - threadpool with completablefuture
* </a>
*/
private final Executor singleThreadExecutor = Executors.newSingleThreadExecutor(); // 큐 + 싱글 쓰레드
// Default folkJoinPool을 사용하는 것으로 변경합니다.
// private final Executor singleThreadExecutor = Executors.newSingleThreadExecutor(); // 큐 + 싱글 쓰레드
private final Set<Long> onGoingTasks = new HashSet<>(); // 현재 처리 중인 작업을 임시 기록 합니다.

/**
Expand All @@ -76,13 +77,13 @@ public class AsyncImageAnalyzePipeline {
// @LogExecution
public void analyze(Long imageLocationId) {
CompletableFuture.runAsync(
() -> onStartTask.accept(imageLocationId), singleThreadExecutor
() -> onStartTask.accept(imageLocationId)
).thenRunAsync(
() -> extractClothAndColorTask.accept(imageAnalyzeManager, imageLocationId), singleThreadExecutor
() -> extractClothAndColorTask.accept(imageAnalyzeManager, imageLocationId)
).thenRunAsync(
() -> colorScoringTask.accept(imageRedisService, imageLocationId), singleThreadExecutor
() -> colorScoringTask.accept(imageRedisService, imageLocationId)
).whenCompleteAsync(
(__, err) -> onCompleteTask.accept(err, imageLocationId), singleThreadExecutor
(__, err) -> onCompleteTask.accept(err, imageLocationId)
);
}

Expand All @@ -106,9 +107,9 @@ public void updateScore(Long imageLocationId, UpdateScoreType updateScoreType)
}

CompletableFuture.runAsync(
() -> pendingTask.accept(UPDATE_SCORE_PENDING_WAIT_MS), singleThreadExecutor
() -> pendingTask.accept(UPDATE_SCORE_PENDING_WAIT_MS)
).thenRunAsync(
() -> this.updateScore(imageLocationId, updateScoreType), singleThreadExecutor
() -> this.updateScore(imageLocationId, updateScoreType)
).orTimeout( /* for safety, throw a TimeoutException in case of a timeout */
UPDATE_SCORE_MAX_TIMEOUT_MS, TimeUnit.MILLISECONDS
);
Expand Down Expand Up @@ -138,8 +139,6 @@ protected boolean isScoreInitialized(Long imageLocationId) {

private final BiConsumer<ImageAnalyzeManager, Long> extractClothAndColorTask = (analyzeManager, imageLocationId) -> {
try {
// add to in-task record
onGoingTasks.add(imageLocationId);
analyzeManager.analyze(imageLocationId);
log.debug("(1) Extract cloth info done - image {}", imageLocationId);
} catch (IOException e) {
Expand Down