[Refactor] 코드 리뷰하면서 확인했던 코드 리팩토링#294
Open
limbaba1120 wants to merge 1 commit intoKernel360:developfrom
Open
Conversation
Collaborator
limbaba1120
commented
Sep 5, 2024
limbaba1120
commented
- UserService: login을 하면 null을 반환하는 코드 예외로 처리
- UserViewController 에 있던 Admin 코드를 Admin Controller로 분리하고 로직 구현을 Service에서 함
- P6SpySqlFormatter: formatter 를 사용하고 싶으면 application.yml 에 format_sql을 false 로 변경해야함.
- UserService: login을 하면 null을 반환하는 코드 예외로 처리 - UserViewController 에 있던 Admin 코드를 Admin Controller로 분리하고 로직 구현을 Service에서 함 - P6SpySqlFormatter: formatter 를 사용하고 싶으면 application.yml 에 format_sql을 false 로 변경해야함.
tigris24
approved these changes
Sep 6, 2024
Collaborator
tigris24
left a comment
tigris24
left a comment
There was a problem hiding this comment.
로그인과 어드민 관련 리팩토링 확인했습니다
| CorsConfiguration corsConfiguration = new CorsConfiguration(); | ||
| corsConfiguration.addAllowedOriginPattern("*"); | ||
|
|
||
| corsConfiguration.addAllowedOriginPattern("https://www.lookus.shop"); |
Collaborator
There was a problem hiding this comment.
이렇게 되면 env에 있는 WEBSITE_DOMAIN이랑 API_DOMAIN을 사용하지 않으시는 것 같은데 comment에 추가해주셨으면 좋겠습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.