Skip to content

Log Errors in Primitives #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Log Errors in Primitives #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87b6aec
errors in primitives get logged
bjfultn Jun 23, 2023
a4635da
errors in primitives get logged
bjfultn Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions keckdrpframework/primitives/base_primitive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def _perform (self):
@author: skwok
"""

import traceback

class BasePrimitive:
"""
Expand All @@ -53,12 +54,16 @@ def _perform(self):
raise Exception("Not yet implemented")

def apply(self):
if self._pre_condition():
self.output = self._perform()
if self._post_condition():
return self.output
try:
if self._pre_condition():
self.output = self._perform()
if self._post_condition():
return self.output
except Exception as e:
self.logger.error(f"Failed executing primitive {self.__class__.__name__}: {e}\n{traceback.format_exc()}")
raise(e)
return None

def __call__(self):
"""
Makes objects of this calls callable.
Expand Down