feat(x/precisebank): Add remainder amount to genesis #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested changes
May 14, 2024
drklee3
changed the title
drklee3
changed the title
drklee3
force-pushed
the
dl-precisebank/03-remainder-type
branch
from
ac78c5d to
0749d76
Compare
nddeluca
approved these changes
May 15, 2024
nddeluca
reviewed
May 15, 2024
nddeluca
reviewed
May 15, 2024
| // IntegerCoinDenom is the denomination for integer coins that are managed by | ||
| // x/bank. This is the "true" denomination of the coin, and is also used for | ||
| // the reserve to back all fractional coins. | ||
| const IntegerCoinDenom = "ukava" |
There was a problem hiding this comment.
Filed #1914, I'm still split if adding the staking and evm keeper params as depedencies is worth it atm or we should pursue this later after the module is complete and we have a better picture of when & where we have to inject those parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(sum(balances) + remainder) % conversionFactor == 0SplitBalancefor splitting up full balances into eachChecklist