Closed
Conversation
ofedoren
force-pushed
the
ruby3
branch
3 times, most recently
from
c1f41a7 to
e5342cf
Compare
Contributor
Author
|
Still red... I think it doesn't pull tasks/dynflow from git?.. 'Cause locally it's green. |
Member
|
[test katello] |
Member
|
Merge conflicts now, something about rubocop.. 🤔 |
Member
|
Also needs a Redmine issue. |
Member
|
The 1 React Tests failure is due to patternfly/patternfly-react#10064, unrelated |
Contributor
Author
|
Closing in favor of #10885. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Updates for kwargs usage across the code base to comply with Ruby 3.0.
Please, review carefully, since there might be a lot of unnecessary changes as well as some breaking changes (such as changing signatures for action planning methods).
Considerations taken when implementing this change?
Depends on
What are the testing steps for this pull request?
Run CI and hope for the best.