Allows building KaGen as static again, a bug that #74 introduced. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhash sets `BUILD_SHARED_LIBS` which forces all libraries to be build as `SHARED`. Previously, we fixed this by calling `set(BUILD_SHARED_LIBS OFF)` before including xxhash, but this cannot be overwritten by the user. This prevents user from building KaGen as a shared library, as noticed in #74. This change no handles that cleanly and gives full control to the user by add `option(BUILD_SHARED_LIBS ...)` at the top of KaGen's CMakeList.txt, as suggested in [1]. [1]: https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxhash sets
BUILD_SHARED_LIBSwhich forces all libraries to bebuild as
SHARED.Previously, we fixed this by calling
set(BUILD_SHARED_LIBS OFF)before including xxhash, but this cannotbe overwritten by the user. This prevents user from building KaGen as
a shared library, as noticed in #74.
This change no handles that cleanly and gives full control to the user
by add
option(BUILD_SHARED_LIBS ...)at the top of KaGen'sCMakeList.txt, as suggested in 1.