Update to ortools v9.14 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeXitoi
reviewed
Aug 19, 2025
| target: impl Into<LinearExpr>, | ||
| exprs: impl IntoIterator<Item = impl Into<LinearExpr>>, | ||
| ) -> Constraint { | ||
| self.add_cst(CstEnum::LinMin(proto::LinearArgumentProto { |
Collaborator
There was a problem hiding this comment.
Why removing this constraint ?
Contributor
Author
There was a problem hiding this comment.
The lin_min constraint was removed from the protobuf definitions (by google) which results into removal CstEnum::LinMin variant.
Collaborator
There was a problem hiding this comment.
The commit you linked keep the implementation of addMinEquality in the C++ interface. Doing so as well here will allow to be backward compatible.
Contributor
Author
There was a problem hiding this comment.
I didn't add it initially, as I thought this was just a pure bindings crate. Nevertheless, I have added it back now. :)
Can you please verify the implementation ?
darshanpatel-arculus
force-pushed
the
update_to_ortools_v914_upstream
branch
from
e884de7 to
e58df07
Compare
darshanpatel-arculus
force-pushed
the
update_to_ortools_v914_upstream
branch
from
e58df07 to
4cf5cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildermethods and doc-tests to use new protobuf types