Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17 add game ending screen #30

Merged
merged 72 commits into from
Feb 25, 2025
Merged

17 add game ending screen #30

merged 72 commits into from
Feb 25, 2025

Conversation

damian-ds7
Copy link
Collaborator

No description provided.

KamilMarszalek and others added 30 commits February 19, 2025 14:09
@KamilMarszalek
Added class for rematch request message
1f59f8b
@KamilMarszalek
Added record WaitingPlayer to simplify waitingQueue
2dd9a05
@KamilMarszalek
Added method for deleting game by id
42ab137
@KamilMarszalek
Implemented rematch logic
164d925
@KamilMarszalek
Simplified delete method
1f53587
@KamilMarszalek
Handled situation when both players send rematch request at the same …
b02fc1d 
…time
@KamilMarszalek
Renamed package
740f647
@KamilMarszalek
Added unit tests to delete method
a884bb7
@KamilMarszalek
Renamed method
efb9788
@KamilMarszalek
Separated constants to new file
65ea005
@KamilMarszalek
Made service use constants
2a66a33
@KamilMarszalek
Added socket documentation
5b522b5
@KamilMarszalek
Changed bare string to enum
e769c81
@KamilMarszalek
Deleted redundant toString call
102db05
@KamilMarszalek
Added rejection message
b0ee33d
@KamilMarszalek
Added new message to documentation
de337e9
@KamilMarszalek
Merge pull request #26 from KamilMarszalek/21-handle-rematch
c9df607 
21 handle rematch
@KamilMarszalek
Added documentation for leaveQueueMessage
c88e2e8
@KamilMarszalek
Added @EqualsAndHashCode to User class
a6601df
@KamilMarszalek
Added leaveQueue message handling
6d06706
@KamilMarszalek
Merge pull request #27 from KamilMarszalek/21-handle-rematch
89c32a5 
Added leaveMessage handling
@damian-ds7
handle enter keypress in username text field
6f7c00e
@damian-ds7
refactor, move common methods to BaseViewModel
58a6258
@damian-ds7
implement serializableNavType function to fix navigation runtime errors
7c3f661
@damian-ds7
move to BaseViewModel
00af7de
@damian-ds7
move GameViewModel to gameScreen package, modify to inherit from Base…
55faeec 
…ViewModel
@damian-ds7
move collection management to a separate function
2fd695e
@damian-ds7
rename GameCreated to GameInfo
9121d1d
@damian-ds7
add connected() function to RealtimeMessageClient
3689ee9
@damian-ds7
implement extension function to convert PlayerColor enum into Result
c34ef52
KamilMarszalek and others added 25 commits February 24, 2025 20:21
@KamilMarszalek
Simplified game service
e5fd17f
@KamilMarszalek
Separated move validation from game service
b34b871
@KamilMarszalek
Changed socket handler message type
c550101
@KamilMarszalek
Changed socket documentation
a7f7d2c
@KamilMarszalek
Merge pull request #28 from KamilMarszalek/backend-refactor
8ac2cee 
Backend refactor
@KamilMarszalek
Fixed injections
da5f4b6
@KamilMarszalek
Refactor
76eacb7
@KamilMarszalek
Refactored doTake method
a923e25
@KamilMarszalek
Merge pull request #29 from KamilMarszalek/backend-refactor
67ea7b2 
Backend refactor
@damian-ds7
add GameId value class
4c5ae89
@damian-ds7
add new message types
af36ecd
@damian-ds7
modify screen states to implement ScreenState interface
044c709
@damian-ds7
add updateState function and _uiState field to BaseViewModel
a82a906
@damian-ds7
modify BaseViewModel to use generic ScreenState
3f61b30
@damian-ds7
add new GameScreenStates
0cda5a9
@damian-ds7
implement methods to handle rematch requests
cdc4e65
@damian-ds7
fix messageCollectionDisposableEffect to work with updated BaseViewModel
3e69147
@damian-ds7
remove REMATCH_PROPOSITION type
1da979f
@damian-ds7
uncomment important code
ef3d4ed
@damian-ds7
add GameIdObject class and extension function to send correct message
8948aee
@damian-ds7
add rematch related popups
58411e9
@damian-ds7
remove rematch lambda
2fdc0cb
@damian-ds7
fix when block
91a7d49
@damian-ds7
fix box size
e6d0a4f
@damian-ds7
remove imports
c02f465
@damian-ds7 damian-ds7 added the enhancement New feature or request label Feb 25, 2025
@damian-ds7 damian-ds7 linked an issue Feb 25, 2025 that may be closed by this pull request
Add game ending screen #17
Closed
KamilMarszalek
KamilMarszalek approved these changes Feb 25, 2025
View reviewed changes
Copy link
Owner

@KamilMarszalek KamilMarszalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@KamilMarszalek KamilMarszalek merged commit 095d054 into main Feb 25, 2025
1 check passed
@damian-ds7 damian-ds7 deleted the 17-add-game-ending-screen branch February 25, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilMarszalek KamilMarszalek KamilMarszalek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add game ending screen
2 participants
@damian-ds7 @KamilMarszalek