tests: support libxml2 2.15 #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dginev
reviewed
Oct 27, 2025
tests/base_tests.rs
Outdated
| && doc_without_whitespace != strip_whitespace(&result_file_legacy) | ||
| { | ||
| panic!( | ||
| "Serialization as HTML of the source XML document is:\n\n{doc_str}\n\nExpected one of:\n\n{result_file}\n\nor\n\n{result_file_legacy}\n" |
Member
There was a problem hiding this comment.
You could have also done an assert!( ... || ... ) rather than a panic! I think.
Contributor
Author
There was a problem hiding this comment.
True, not sure why I made it that convoluted…
wetneb
force-pushed
the
libxml2.15-support
branch
from
997e4ff to
702f91c
Compare
Member
|
Thank you for the speedy report and resolution, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187.