BUG: fixed bug with multiplicative observation error#53
BUG: fixed bug with multiplicative observation error#53drdunmire1417 wants to merge 1 commit intoKUL-RSDA:archive/master-kulfrom
Conversation
| std(g) = obsstd(g)*value1(g) | ||
| if(std(g).eq.0) std(g) = 0.1 | ||
|
|
||
| if(std(g).eq.0) then ! if observation std = 0, calculate std of model ensembles |
There was a problem hiding this comment.
This is a good fix for snow DA, and for our specific application. However, (1) I can imagine objections about passing information on the obs_predictions into the generation of observation specs, but do not have an efficient alternative right away. Maybe it needs to be a separate 'post'-observation routine, that kicks in for specific observation types, but I am not sure. (2) If this is done in the enkf, do we need something similar in the other DA tools? Both concerns are just to keep in mind - I am not saying that we need to do it now.
There was a problem hiding this comment.
On (1): We could consider including in the pert_attrbs a user-defined parameter that defines a minimum obs error in the case of the multiplicative obs error option. This would make it obsolete to pass the obs_predictions. This would also solve the problem that an obs value slightly above 0 would cause a switch to the else statement which results in an abrupt change of the error from one time step to the other. This could be avoided by using this minimum obs error for low values in the observations.
mbechtold
changed the title
mbechtold
left a comment
mbechtold
left a comment
There was a problem hiding this comment.
Great this option becomes usable with that bug fix.
3 participants
Fixed bug with the implementation of the multiplicative observation error for the ensemble kalman filter