Open
Conversation
Collaborator
|
Update: the goal of this PR is to avoid that the HI keeps increasing (plant continues to form yield), even after the crop is in the senescence or dormant phase, for crops with high CCo. Initially, the problem was detected for winter wheat and caught in a way by PR#373. The current PR#376 also solves the issue for indeterminate crops. |
gdelannoy
approved these changes
Feb 4, 2026
src/global.f90
Outdated
| .and. (GetCrop_subkind() /= subkind_Forage)) then | ||
| CCthreshold = PercCCxHIfinal | ||
| if ((100* GetCrop_CCo()) > PercCCxHIfinal) then | ||
| CCthreshold = (100* (1.1*GetCrop_CCo())) |
Collaborator
There was a problem hiding this comment.
possibly 100._dp for perfection in both lines, but this is likely safe too.
lbusschaert
approved these changes
Feb 5, 2026
Collaborator
lbusschaert
left a comment
lbusschaert
left a comment
There was a problem hiding this comment.
Looks good! Thanks, Michel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the harvest index adjustment logic to make it robust for crops with higher initial canopy cover (CCo). The threshold for reducing the final harvest index is now bounded by a minimum derived from CCo, preventing unrealistically early HI limitation for crops such as wheat with relatively large CCo values.