V73: testcase input and reference output updated#375
V73: testcase input and reference output updated#375mbechtold wants to merge 5 commits intoKUL-RSDA:mainfrom
Conversation
lbusschaert
left a comment
lbusschaert
left a comment
There was a problem hiding this comment.
Minor comments/wonderings
| 100 : Calibrated response (%) of stomata stress to ECsw (Range: 0 (none) to +200 (extreme)) | ||
| 1.15 : Crop coefficient when canopy is complete but prior to senescence (KcTr,x) | ||
| 0.050 : Decline of crop coefficient (%/day) as a result of ageing, nitrogen deficiency, etc. | ||
| 11 : Cumulative decrease (%) at maturity of crop coefficient as a result of ageing, nitrogen deficiency, etc. |
There was a problem hiding this comment.
So the definition of the parameter changed? Or was it wrongly defined. Maybe I'll have my answer after reviewing all the PRs
There was a problem hiding this comment.
The definition of the parameter changed including the routines that use this parameter. So nothing was 'wrong' before. It's now a better representation of the decline.
testcase/DATA/Ottawa.MAN
Outdated
| @@ -1,5 +1,5 @@ | |||
| Ottawa, Canada | |||
| 7.2 : AquaCrop Version (August 2024) | |||
| 7.3 : AquaCrop Version (January 2026) | |||
There was a problem hiding this comment.
detail but don't we want to keep the description aligned in the files?
There was a problem hiding this comment.
corrected with next push
| 17.0 : Water Productivity normalized for ETo and CO2 (WP*) (gram/m2) | ||
| 100 : Water Productivity normalized for ETo and CO2 during yield formation (as % WP*) | ||
| 50 : Crop performance under elevated atmospheric CO2 concentration (%) | ||
| 100 : Crop performance under elevated atmospheric CO2 concentration (%) |
There was a problem hiding this comment.
Any reason why this default parameter is changed again? It's important for climate impact studies.
There was a problem hiding this comment.
Good question. The Ottawa case runs actually with 50%. This is just the DEFAULT.CRO that is always written out by an AquaCrop run. It is hardcoded in the defaultcropsoil.f90 to be 100. Maybe it was 50% in an earlier version. I will ask Dirk whether he wants to have it to be by default 100 as it is now or 50 as for all crops in his database. Currently the hardcoded default parameter line is this:
call SetCrop_AdaptedToCO2(100_int8) ! Percentage adapted to elevated atmospheric
! CO2 concentration
There was a problem hiding this comment.
From Dirk: We have decided that the default is 100, after a publication which mentioned that the CO2 measurement in the FACE experiment were not accurate.
| 2023 421.08 | ||
| 2025 425.08 | ||
| 2099 573.08 | ||
| 2024 424.61 |
There was a problem hiding this comment.
Why did we remove 2025 and replace it by 2030?
There was a problem hiding this comment.
Because the 2025 was a prediction in the last version. There is now measured data for 2024 and the extrapolation to the future now goes to 2030 and then 2099.
3 participants
This PR updates the testcase input and reference output to version 7.3.