Open
Conversation
gdelannoy
approved these changes
Jan 27, 2026
lbusschaert
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that appears sporadically in space and time in GDD mode when rooting depth drops to zero right before harvest.
The bug originates from a mismatch for the end of season checks in calendar days and GDDays in section 7 of run.f90
It occurs for some pixels and years that SumGDD is still smaller than GDDaysToHarvest while (DayNri-Simulation.DelayedDays) is already larger than Crop.DayN.
This leads to entering the else of the inner if statement which sets rooting depth to zero.
In GDD mode, it only affects the last day before harvest when rooting depth drops to zero and then jumps back again to the original depth it had before the drop.