[feat] @everyone 이 첫줄 이어도 title로 사용하지 않습니다. #442
Merged
Conversation
seongjunnoh
reviewed
Apr 3, 2025
| @@ -8,6 +8,7 @@ | |||
| public class TitleAndContentParser { | |||
Collaborator
There was a problem hiding this comment.
확실히 객체 분리 해놓으니까 유용하게 쓰이네요 굳!!!
| public class TitleAndContentParser { | ||
| private String title; | ||
| private String content; | ||
| private static final String EVERYONE_MENTION = "@everyone"; |
Collaborator
There was a problem hiding this comment.
static final 상수 설정 좋습니다!
| return new TitleAndContentParser(title,content); | ||
| } | ||
|
|
||
| private static boolean validateTitle(String line){ |
| return true; | ||
| } | ||
|
|
||
| private static String deleteMention(String input){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 요약
@everyone은 제목으로 설정하지 않음 #439🔖 변경 사항
✅ 리뷰 요구사항
📸 확인 방법 (선택)
📌 PR 진행 시 이러한 점들을 참고해 주세요