Conversation
MMESV Configs, heavily oriented on the SSPX configs by Tagir-1. Defenetly needs to be looked over and refinded. But its a start.
|
see also: KSP-RO/ROKerbalism#112 |
| @PART[Benjee10_MMSEV_adapter_0-9375]:FOR[RealismOverhaul]:NEEDS[Benjee10_MMSEV] | ||
| { | ||
| %RSSROConfig = True | ||
| %rescaleFactor = 1.8 | ||
|
|
||
| @title = 2.25m to 1.6875m Adapter PT-091A | ||
| @description = This low-profile adapter provides a connection between 2.25m and 1.6875m bulkhead profiles. | ||
| @tags = planetside, exploration, technologies, station, radial, attach | ||
|
|
||
| @maxTemp = 773.15 | ||
| @skinMaxTemp = 773.15 | ||
| @crashTolerance = 10 | ||
|
|
||
| @mass = 0.5 | ||
| } |
There was a problem hiding this comment.
Would help readability IMO to extract the portions of these patches applied everywhere into a separate patch. Specifically that rescaleFactor, maxTemp, skinMaxTemp, and crashTolerance are the same in every patch. Instead:
@PART[Benjee10_MMSEV*]:FOR[RealismOverhaul]
{
%rescaleFactor = 1.8
@maxTemp = 773.15
@skinMaxTemp = 773.15
@crashTolerance = 10
}
Place this patch at the top of the file, then anything further in can deviate if needed,
|
|
||
| @mass = 0.5 | ||
| } | ||
| @PART[Benjee10_MMSEV_crewTube0]:FOR[RealismOverhaul]:NEEDS[Benjee10_MMSEV,RealFuels] |
There was a problem hiding this comment.
NEEDS[Benjee10_MMSEV] is unnecessary since the part won't exist without it. Remove throughout.
Either remove the RealFuels NEEDS (because RO deps RealFuels anyway) -or- just move it to the only PartModule that requires it: ModuleFuelTanks
| @MODULE[ModuleFuelTanks] | ||
| { | ||
|
|
||
| TANK | ||
| { | ||
| name = ElectricCharge | ||
| amount = 5000 | ||
| maxAmount = 5000 | ||
| } | ||
| } |
There was a problem hiding this comment.
Declaring the module and then immediately patching it is a strange pattern. Put these two together here [and everywhere].
I realize you used the SSPX configs as a template for these things that I'm commenting on. I recently went through and changed these patterns in the SSPX files,
|
|
||
| @maxTemp = 773.15 | ||
| @skinMaxTemp = 773.15 | ||
| } No newline at end of file |
|
I will take a look in two weeks, away for holidays, so no time to change this. |
|
Might you have a chance to come back to this soon? |
|
Of course I forgot this existed :D |
|
Iam sorry guys, right now i cant find the time and motivation to correct and update it. To much on my plate with family stuff. |
I did at least the fast basic changes. For more i will need to find time...
|
Has there been any updates on this since when it was last updated? |
4 participants
MMESV Configs, heavily oriented on the SSPX configs by Tagir-1.
Should be looked over. But its a start.