Skip to content

Comments

Add Harmony2 dependency to LMP, update compatibility#8591

Merged
DasSkelett merged 3 commits intoKSP-CKAN:masterfrom
DasSkelett:fix/LMP-0.28
Jun 25, 2021
Merged

Add Harmony2 dependency to LMP, update compatibility#8591
DasSkelett merged 3 commits intoKSP-CKAN:masterfrom
DasSkelett:fix/LMP-0.28

Conversation

@DasSkelett
Copy link
Member

@DasSkelett DasSkelett commented Jun 25, 2021

The new release 0.28.0 now bundles Harmony2 (updated from Harmony1).
It is also released for KSP 1.12.

After talking to the author, we've decided to filter the Harmony DLL, and replace it with a dependency on our indexed Harmony2 module (the HarmonyKSP "mod").

They author might switch over to bundling HarmonyKSP themself, which would allow us to get rid of the filter, and make sure that both CKAN users and manual installers would have the same distributions of Harmony installed.
Since this wouldn't need a change in our metadata (besides removing the filter stance), I'm going to go ahead with this change already.

Also see LunaMultiplayer/LunaMultiplayer#415

ckan compat add 1.11

@DasSkelett DasSkelett merged commit 14744f8 into KSP-CKAN:master Jun 25, 2021
@DasSkelett DasSkelett deleted the fix/LMP-0.28 branch June 25, 2021 15:53
@HebaruSan
Copy link
Member

HebaruSan commented Jun 25, 2021

Was dropping the vref intentional?
Ahh, just spotted the comment, got it.

@DasSkelett
Copy link
Member Author

The vref has been dropped a long time ago, in #8281.
Also #8429 (comment)

It is still broken currently, at the time of the release it wasn't updated at all, a few minutes ago the remote file has been updated in LunaMultiplayer/LunaMultiplayer#431, but still forgot to bump VERSION.

So I won't re-add the vref in the foreseeable future, the author is far to unreliable in this regard.

@enderger
Copy link

Yeah, sorry 'bout that. I've published a PR to fix that (LunaMultiplayer/LunaMultiplayer#432), I'm a bit new to the KSP modding scene and didn't recognize that it needed to get bumped.

@DasSkelett
Copy link
Member Author

No worries @enderger, you made a step in the right direction.
We still won't be able to add the vref back to the netkan, since the .version file embedded in the released zip still has the incorrect VERSION property. This would require a new release, but even then we probably won't add it back, since it's too unreliable in this mod's case. Manually updating hardcoded compat data in the netkan once a year is easier than having to go back and fixup old metadata, and less disruptive for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants