Exclude version files with syntax errors from warnings#3328
Merged
HebaruSan merged 1 commit intoKSP-CKAN:masterfrom Mar 21, 2021
Merged
Exclude version files with syntax errors from warnings#3328HebaruSan merged 1 commit intoKSP-CKAN:masterfrom
HebaruSan merged 1 commit intoKSP-CKAN:masterfrom
Conversation
HebaruSan
added
Enhancement
DasSkelett
approved these changes
Mar 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In #3327 we eliminated some false positives for the "vref absent" warnings.
KSP-CKAN/NetKAN#8429 attempted to address the remaining warnings, which revealed that they were mostly version files with syntax errors.
Motivation
We can't use a version file with a syntax error, so those are still false positives in a sense, but in case one of those mods releases a new version with a fixed syntax error, it would be nice to know about it.
Changes
Now we try to parse the version file, and if there's a syntax error, we don't print the warning. This will cut down on non-actionable warnings on the status page.
If the syntax error ever gets fixed, the warning will come back, which will trigger the usual Discord notification.