Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos embedding python and Qt5.11.1 bugfix #138

Merged

Conversation

thomaslima
Copy link
Collaborator

I tested this on Mac OS with qt11.1 installed from brew.
Closes #100

feature:

  • MacOS compilations can embed python's dynamic libraries with the app bundle

bugfix:

  • Qt5.11 complains about using Qt::blue and similar as a valid QColor

@thomaslima
Copy link
Collaborator Author

I have included a build from this PR in https://www.dropbox.com/sh/9t3f8yp5edztl6f/AADGWeZpjJgPh5HBwHXGmraYa?dl=0

klayout-0.25.3-macOS-HighSierra-1-Qt5111brew-Py365-896f734.dmg

@klayoutmatthias
Copy link
Collaborator

Thanks a lot for taking care of this!

I have to merge that to the 0.26 development branch now I separated that. But that's not an issue.

Thanks and best regards,

Matthias

@klayoutmatthias klayoutmatthias merged commit b64d14e into KLayout:master Jun 28, 2018
klayoutmatthias added a commit that referenced this pull request Jun 28, 2018
Merge commit '896f7347f0b2cf947492ff3cc5d708df1b81af29' into 0.26
@thomaslima thomaslima deleted the macos_embedding_python_pr branch June 29, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(macOS Improvement) Packaging python3 with klayout.app
2 participants