Skip to content

bugfixes and feature additions#29

Open
a-monsch wants to merge 21 commits intomainfrom
sm_devs
Open

bugfixes and feature additions#29
a-monsch wants to merge 21 commits intomainfrom
sm_devs

Conversation

@a-monsch
Copy link
Copy Markdown
Contributor

@a-monsch a-monsch commented Mar 5, 2026

This PR handles the three main topics:

  1. Fixing the FF calculation by replacing the fraction purity estimation with histogram subtraction
  2. Adding a pruning option for corrections of data that is dominated by fluctuations
  3. Adding a preliminary ML interface for NN derived fake factors.

@a-monsch a-monsch requested a review from nshadskiy March 5, 2026 17:12
Copy link
Copy Markdown
Collaborator

@nshadskiy nshadskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of new features is still missing. Will add it asap

@nshadskiy
Copy link
Copy Markdown
Collaborator

#30 is added in this PR

@a-monsch
Copy link
Copy Markdown
Contributor Author

there seems to be an issue now for cases where a 2D split is used during FF calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants