Move get_alternate_file_uri from create_branch_map() into run()#89
Merged
Move get_alternate_file_uri from create_branch_map() into run()#89
Conversation
nshadskiy
approved these changes
Apr 29, 2026
Contributor
nshadskiy
left a comment
nshadskiy
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_alternate_urifunction has been introduced with pull request #73 to find an URI, under which a NANOAOD file is accessible. The function has been executed in thecreate_branch_mapmethod ofCROWNRun, causingstatoperations to be issued every time whencreate_branch_mapis called for every NANOAOD file in the respective sample lists, even if thentuplefiles are already present.The execution of the
get_alternate_urifunction has been moved torun(). Now, the check for the existence of a NANOAOD file is only checked if the NANOAOD -> ntuple step is actually performed, i.e., only once when actually running the processing.