Adding functionality to set files_per_task per sample type#85
Adding functionality to set files_per_task per sample type#85
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for overriding files_per_task based on a dataset’s sample_type (as defined in the sample database), configured via KingMaker_luigi.cfg.
Changes:
- Introduce a
custom_files_per_taskluigi parameter (dict) to support per-sample_typeoverrides. - Apply
custom_files_per_taskduring branch map creation inCROWNRunto adjust task splitting. - Update
KingMaker_luigi.cfgwith a newcustom_files_per_taskoption and related documentation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| processor/tasks/CROWNRun.py | Applies the per-sample_type override when determining files_per_task for branch splitting. |
| processor/tasks/CROWNBase.py | Adds the custom_files_per_task luigi parameter to workflow tasks. |
| processor/framework.py | Changes default nanoAOD_version value (appears unrelated to PR goal). |
| lawluigi_configs/KingMaker_luigi.cfg | Adds config option and docs for custom_files_per_task; also adjusts a section header line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This change adds the functionality in
KingMaker_luigi.cfgto further customizefiles_per_taskargument to optionally set it persample_typeas specified indatasets.jsonofsample_database