Conversation
Contributor
Author
|
Related tasks that are not part of this PR:
|
…date CROWN submodule.
… simplified with introduction of sandboxing.
…Maker env file with previous kingmaker-images hash to allow for testing until local cvmfs is adjusted.
…onment when no container is provided to the sandbox parameter.
…g or no sandboxing is used for CROWN workflow.
… sample_database.
Contributor
Author
|
Additional goals for the PR have been reached.
|
Apply PR
nshadskiy
reviewed
Apr 9, 2026
nshadskiy
reviewed
Apr 29, 2026
|
|
||
| ```python | ||
| re.match(r"^root:\/\/[^\/]\/+(.*)$", file) | ||
| re.match(r"^root:\\/\\/[^\\/]\\/+(.*)$", file) |
Contributor
There was a problem hiding this comment.
It's just documentation, but I guess this should match the actual code down below?
Contributor
Author
There was a problem hiding this comment.
The escaping of the \ is kind of necessary for the comment as it is not interpreted as a raw string in a printout (due to the ```).
Not sure if there is a better way.
nshadskiy
reviewed
Apr 29, 2026
nshadskiy
reviewed
Apr 29, 2026
nshadskiy
reviewed
Apr 29, 2026
nshadskiy
reviewed
Apr 29, 2026
nshadskiy
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves on the environment procurement in the following ways:
This approach allows for a single container image to be usable for all x64 architectures instead of the current setup that only works with specific distros and versions.
Also allows for greater flexibility for future changes in the environment past the software available through LCG stacks.
As a result, the split setup through the kingmaker-images submodule can be retired after sufficient testing of the new environment.
The final goal is to then also deploy the production container image via cern cvmfs unpacked.
CROWN was originally kept as an "at setuptime" clone of the repo, but as the software becomes more stable, submoduling makes more sense.
See CROWN PR for further changes.
Various changes were necessary to allow for consistent behaviour both remote and local. Therefore, the new CROWN branch will be incompatible with older versions of Kingmaker and vice versa.