Open
Conversation
…et corrections in the same way '
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 6 complexity · 0 duplication
Metric Results Complexity 6 Duplication 0
TIP This summary will be updated as you push new changes. Give us feedback
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new event-level helpers to support embedding workflows (muμ → ee), and extends code generation configuration with additional sample-type flags plus a safer config cleanup loop.
Changes:
- Added embedding-muon charge matching utilities (
MatchEmbeddingMuonP4ByCharge,HasEmbeddingMuonChargeMatch) and an opposite-charge helper (HasOppositeCharge). - Extended
Configuration._set_sample_parameters()with explicitis_data,is_dyjets, andis_wjetsboolean flags; made_remove_empty_configkeys()safe against mutation during iteration. - Added
.codexto.gitignore.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/event.cxx | Implements new charge-based embedding-muon matching helpers and opposite-charge flag helper. |
| include/event.hxx | Exposes declarations for the new event::quantity helpers. |
| code_generation/configuration.py | Adds extra sample flags and fixes dict-key iteration during deletion. |
| .gitignore | Ignores .codex artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #include "../include/utility/Logger.hxx" | ||
| #include "ROOT/RDataFrame.hxx" | ||
| #include "TRandom3.h" | ||
| #include <cmath> |
Comment on lines
+145
to
+150
| auto has_match = [](const int &reco_q, | ||
| const float &emb_q_1, | ||
| const float &emb_q_2) { | ||
| return static_cast<int>(reco_q == static_cast<int>(emb_q_1) || | ||
| reco_q == static_cast<int>(emb_q_2)); | ||
| }; |
| sample_parameters["is_data"] = False | ||
| if "dyjets" in self.sample: | ||
| sample_parameters["is_dyjets"] = True | ||
| else: |
nshadskiy
reviewed
May 5, 2026
Comment on lines
+162
to
+173
| if "data" in self.sample: | ||
| sample_parameters["is_data"] = True | ||
| else: | ||
| sample_parameters["is_data"] = False | ||
| if "dyjets" in self.sample: | ||
| sample_parameters["is_dyjets"] = True | ||
| else: | ||
| sample_parameters["is_dyjets"] = False | ||
| if "wjets" in self.sample: | ||
| sample_parameters["is_wjets"] = True | ||
| else: | ||
| sample_parameters["is_wjets"] = False |
Contributor
There was a problem hiding this comment.
Why is this needed? This is already done by the if else above.
nshadskiy
reviewed
May 5, 2026
| None | ||
| """ | ||
| for key in config: | ||
| for key in list(config.keys()): |
Contributor
There was a problem hiding this comment.
Was this breaking anything?
nshadskiy
reviewed
May 5, 2026
Comment on lines
+148
to
+149
| return static_cast<int>(reco_q == static_cast<int>(emb_q_1) || | ||
| reco_q == static_cast<int>(emb_q_2)); |
nshadskiy
reviewed
May 5, 2026
| const std::string &outputname, | ||
| const std::string &q_1, | ||
| const std::string &q_2) { | ||
| auto has_opposite_charge = [](const int &q_1, const int &q_2) { |
Contributor
There was a problem hiding this comment.
Why are here the charges integer but in the other functions floats?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.