-
Notifications
You must be signed in to change notification settings - Fork 48
feat: reset team on refund #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Tests currently failing (fix TBD in another PR): - [ ] Team cannot be reset when pool is not live (fixed by #786)
c59b04b
to
1ad53b2
Compare
@rflechtner What is this? |
We can pick this up after trialing the pallet on a testnet. We're currently not quite sure if we want to reset the asset admins when the pool moves to refunding state. This would do it, but would need to be benchmarked properly. |
62680ee
to
305e8a7
Compare
305e8a7
to
59856a5
Compare
@rflechtner Can we also close this? |
Mhh this is something that would still make sense, although I don't see that this gets any priority |
Suggested change to avoid unexpected changes to currencies and issuances while refunding. This resets all asset teams to the pool account when calling
start_refund
.This is waiting for a runtime implementation of our new pallet so that we can see the impact on the transaction weight that this has.
Checklist:
array[3]
useget(3)
, ...)