Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for Widget window in Qt Quick #4

Merged
merged 5 commits into from
Mar 6, 2025
Merged

Add example for Widget window in Qt Quick #4

merged 5 commits into from
Mar 6, 2025
+608 −0

Conversation

Cuperino
Copy link
Contributor

@Cuperino Cuperino commented Nov 19, 2024 •
edited
Loading

Example app where a window bounces across the screen, like an old DVD player's logo would. You control the text through one of two identical forms, one implemented in QML and the other in Widgets. The example code follows best practices.

Please note that because the app doesn't work on Wayland because it manipulates the window's position. If you try it on Linux, make sure to run X11.

dfaure-kdab
dfaure-kdab requested changes Nov 26, 2024
View reviewed changes
@Cuperino Cuperino force-pushed the master branch 2 times, most recently from 7a46179 to 565e953 Compare January 31, 2025 17:45
@Cuperino Cuperino requested a review from dfaure-kdab January 31, 2025 18:36
dfaure-kdab
dfaure-kdab requested changes Jan 31, 2025
View reviewed changes
@Cuperino Cuperino requested a review from dfaure-kdab February 1, 2025 03:09
dfaure-kdab
dfaure-kdab requested changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@dfaure-kdab dfaure-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there... for the C++ code. I can't review the QML code, you'll want to find someone else for that.

@Cuperino
Add example for Widget window in Qt Quick
53cf643 
Example app wher a window bounces across the screen,
like an old DVD player's logo would. You control
the text through one of two identical forms,
one implemented in QML and the other in Widgets.
The example code follows best practices.

Due to limitations with Wayland, it only works on
X11 on Linux.
@Cuperino Cuperino requested a review from dfaure-kdab February 1, 2025 14:17
@Cuperino Cuperino requested a review from renatofilho February 6, 2025 03:08
@Cuperino
Copy link
Contributor Author

Cuperino commented Feb 7, 2025

I had people from my team, Initech, review the code. All of their suggestions have now been incorporated.

@dfaure-kdab dfaure-kdab merged commit bc5766a into KDABLabs:master Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatofilho renatofilho renatofilho approved these changes

@dfaure-kdab dfaure-kdab dfaure-kdab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cuperino @renatofilho @dfaure-kdab