Conversation
…_entity refactor: 백신 엔티티(접종시기) 리팩토링
feat: vaccination v2 작성
Closed
3 tasks
Test Results22 tests +4 17 ✅ +4 8s ⏱️ +3s For more details on these failures, see this check. Results for commit c8b94a1. ± Comparison against base commit ff5a9c8. ♻️ This comment has been updated with latest results. |
2dhhh
reviewed
Mar 19, 2025
Collaborator
There was a problem hiding this comment.
생성자 of로 통일하기로 하지 않았나요?
혹시 준희님 코드에 맞춰서 저렇게 일부로 수정하신건가요?
jun23314
reviewed
Mar 20, 2025
|
|
||
| @Query("SELECT v FROM Vaccination v WHERE v.pet = :pet ORDER BY v.timeYear DESC, v.timeMonth DESC, v.timeDay DESC") | ||
| List<Vaccination> findAllByMemberAndPet(@Param("pet") Pet pet); | ||
| List<Vaccination> findAllByPetOrderByVaccinatedAtDesc(@Param("pet") Pet pet); |
Contributor
| List<Vaccination> findAllByPetOrderByVaccinatedAtDesc(@Param("pet") Pet pet); | ||
|
|
||
| default @NonNull Vaccination getById(@NonNull Long id) { | ||
| return findById(id).orElseThrow(VaccinationNotFoundExceptionV2::new); |
Collaborator
Author
There was a problem hiding this comment.
interface 구현에 따라서, validation 적용
| @PathVariable Long petId, | ||
| @RequestBody CreateVaccinationRequest request) { | ||
| vaccinationService.createVaccinationInfo(loginInfo.memberId(), petId, request); | ||
| vaccinationService.createVaccinationInfo(petId, request); |
Contributor
There was a problem hiding this comment.
왜 제대로된 LoginInfo인지 확인은 안해주나요,,
…refactor/#215_vaccination
2dhhh
pushed a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용