Skip to content

Comments

I completed the assignment#1

Open
JxZhang15 wants to merge 1 commit intomainfrom
assignment-1
Open

I completed the assignment#1
JxZhang15 wants to merge 1 commit intomainfrom
assignment-1

Conversation

@JxZhang15
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I added Python code to complete the requests

What did you learn from the changes you have made?

I learnt about the python code

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

N/A

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes, I do face some challenges during writing the code like typo errors and missing the symbol

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants