Skip to content

4 issues: #1368, #1366, #1365, #1329 - #1481

Open
Otaiki1 wants to merge 2 commits into
Junirezz:mainfrom
Otaiki1:prmaster/1368-1366-1365-1329-4-issues-1368-1366-1365-1329-dd74f1
Open

Otaiki1 wants to merge 2 commits into
Junirezz:mainfrom
Otaiki1:prmaster/1368-1366-1365-1329-4-issues-1368-1366-1365-1329-dd74f1

Conversation

@Otaiki1

@Otaiki1 Otaiki1 commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1368
Closes #1366
Closes #1365
Closes #1329

Closes #1368: Synchronous throws inside async Express handlers hang requests until timeout

Fixed synchronous throws in async Express handlers that caused requests to hang for 30 seconds until timeout.

Changes:

  • POST /admin/allowlist/add: Removed redundant validation throws (validation middleware handles 400)
  • DELETE /admin/allowlist/remove: Replaced throw new NotFoundError() with inline res.status(404).json() + return
  • GET /admin/impersonate/:wallet: Replaced throw new ValidationError() and throw new ForbiddenError() with inline 400/403 responses
  • POST /admin/api-keys/register: Replaced throw new ValidationError() and throw new ForbiddenError() with inline 400/403 responses
  • PATCH /admin/webhooks/:id: Replaced throw new NotFoundError() with inline 404 response

All fixes use the pattern res.status(XXX).json({...}); return; to properly send error responses without leaving requests hanging in Express 4.

Closes #1366: Schema snapshots drift when new health-check fields are added to /health or /ready

Stopped early by the maintainer, who reviewed the work so far. Includes changes to backend/schema-snapshots/get-_health.json, backend/schema-snapshots/get-_ready.json, backend/src/__tests__/issues711.test.ts, backend/src/apiContractSnapshots.ts, backend/src/swagger.ts, backend/src/__tests__/openApiContractTests.test.ts.


Opened with PRmaster after human review.

…ests

Replace synchronous error throws in async route handlers with inline
responses. Express 4 does not catch pre-await throws, causing requests
to hang for 30s until timeout. Fixed 5 admin endpoints:
- POST /admin/allowlist/add
- DELETE /admin/allowlist/remove  
- GET /admin/impersonate/:wallet
- POST /admin/api-keys/register
- PATCH /admin/webhooks/:id

Closes Junirezz#1368
@drips-wave

drips-wave Bot commented Sep 27, 2026

Copy link
Copy Markdown

@Otaiki1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment