chore(deps): add general label to all dependabot ecosystems (#1460) - #1477
Open
amehsamuel200225-sketch wants to merge 1 commit into
Open
amehsamuel200225-sketch wants to merge 1 commit into
amehsamuel200225-sketch wants to merge 1 commit into
Conversation
|
@amehsamuel200225-sketch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1460
Summary
Adds the
generallabel to all four Dependabot ecosystems in.github/dependabot.yml, so dependency PRs are tagged consistently for triage-board filtering.This implements the first option in the acceptance criteria ("Configure
dependabot.ymllabels: [dependencies, general]"). The alternative — anauto-labelworkflow gated onif: actor == 'dependabot[bot]'— was not used, because the native Dependabotlabels:key is the supported mechanism and the file already uses it.Changes
.github/dependabot.yml— added- "general"to thelabels:list of all fourupdatesentries (npm/frontend,npm/backend,cargo/,github-actions/). Existingdependencies,security, andgithub-actionslabels were preserved; this is purely additive.Findings for maintainers
Three things surfaced while implementing this that are worth flagging, since the issue's premise did not match the repository:
Labels were already configured. The issue states Dependabot "opens PRs without labels," but every ecosystem already declared a
labels:list. The only genuinely missing label wasgeneral, which is what this PR adds.The configured labels do not exist in the repository.
gh label listshows 19 labels in this repo;dependencies,security, andgithub-actionsare not among them (onlygeneralexists). Dependabot applies labels by name and silently skips ones that do not exist, so the configureddependencieslabel is unlikely to be applied to any PR. This needs a maintainer with admin rights to create those labels, or a change to reference existing ones. I could not do this from a fork PR. This is the part of the issue that is genuinely unfixed.The reported symptom was never observed.
gh pr list --author "dependabot[bot]" --state allreturns zero PRs — Dependabot has never opened one in this repository, so the "15 unlabeled dependabot PRs per week" backlog described in the issue does not exist. Note thatdependabot.ymltargets/frontendand/backendnpm directories; if the frontend/backend lockfiles are current there may simply be nothing to update.Acceptance criteria status
dependabot.ymllabels: [dependencies, general]—generaladded to all four ecosystems.-label:dependencies— not deliverable in a PR. This is a GitHub Project board view configuration, applied in the board UI or project settings. Needs a maintainer, and is also blocked on finding #2 above (thedependencieslabel must exist first for the filter to be meaningful).dependencieslabel — not performed. A dummy PR cannot reproduce Dependabot's own labeling behaviour, and the repo has no Dependabot PRs to inspect. Verification instead covered: all four ecosystems parse with the expected label sets, and label indentation is valid. Empirically confirming the label lands requires waiting for a real Dependabot PR after thedependencieslabel is created.Validation
.github/dependabot.yml: 4package-ecosystementries, 4dependencieslabels, 4generallabels, 0 indentation issues.git diff --check— clean.