Skip to content

ci: enforce backend types and contract formatting - #1425

Open
kingeligma wants to merge 1 commit into
Junirezz:mainfrom
kingeligma:fix/984-add-guided-onboarding-checklist-for-first-time-depositors
Open

kingeligma wants to merge 1 commit into
Junirezz:mainfrom
kingeligma:fix/984-add-guided-onboarding-checklist-for-first-time-depositors

Conversation

@kingeligma

Copy link
Copy Markdown
Contributor

Summary

Resolves the four assigned issues with focused CI, cache, OpenAPI, and Rust contract changes.

Changes

Validation

Passed:

  • npm ci --ignore-scripts --no-audit --no-fund in backend
  • npm run lint in backend (0 errors)
  • focused backend Jest tests: 5 passed
  • npm run generate:openapi
  • cargo fmt --all -- --check

Known baseline blockers documented for follow-up:

  • npm run build currently reports 92 pre-existing TypeScript errors across Prisma model drift, logger APIs, telemetry, and unrelated modules.
  • cargo test --workspace --locked reaches pre-existing Soroban contract compile errors, including missing VaultError, an overlong contract function name, and invalid BridgeError conversion signatures.

No CI failure is hidden or made non-blocking; #1381 intentionally adds the TypeScript build gate so these existing errors become visible to maintainers.

Fixes #1381
Fixes #1379
Fixes #1323
Fixes #1331

Copilot AI lite review requested due to automatic review settings September 26, 2026 14:19
@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@kingeligma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants