ci: enforce backend types and contract formatting - #1425
Open
kingeligma wants to merge 1 commit into
Open
kingeligma wants to merge 1 commit into
kingeligma wants to merge 1 commit into
Conversation
|
@kingeligma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the four assigned issues with focused CI, cache, OpenAPI, and Rust contract changes.
Changes
npm run prisma:generateandnpm run build; backend/package-lock is synchronized sonpm cisucceeds.HealthResponseOpenAPI schema with all dependency checks, includingchecks.indexer, wired/healthto it, regeneratedbackend/openapi.json, and added a contract assertion.Cargo.lockso locked workspace commands resolve the existing contract package.Validation
Passed:
npm ci --ignore-scripts --no-audit --no-fundinbackendnpm run lintinbackend(0 errors)npm run generate:openapicargo fmt --all -- --checkKnown baseline blockers documented for follow-up:
npm run buildcurrently reports 92 pre-existing TypeScript errors across Prisma model drift, logger APIs, telemetry, and unrelated modules.cargo test --workspace --lockedreaches pre-existing Soroban contract compile errors, including missingVaultError, an overlong contract function name, and invalidBridgeErrorconversion signatures.No CI failure is hidden or made non-blocking; #1381 intentionally adds the TypeScript build gate so these existing errors become visible to maintainers.
Fixes #1381
Fixes #1379
Fixes #1323
Fixes #1331