[975] Frontend: Implement account risk summary card with actionable warnings - #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RiskSummaryCardfromVaultDashboard.tsxinto a presentationalfrontend/src/components/RiskSummaryCard.tsxthat receives all copy via props, exposes itself as a labelledrole="region", and announces warning changes viaaria-live="polite".healthyActionCTA to the all-clear state; the dashboard passes a "Compare strategies" action that navigates to/compare.vaultDashboard.riskSummary.*inen.tsand mirrors it with Spanish translations ines.ts; the XLM-fee warning CTA label changes from "Adjust amount" to "Review deposit".RiskSummaryCard.test.tsxcovering warning rendering + CTA click handlers, the labelled region, the all-clear state with/without the healthy CTA, and singular vs. plural badge labels.docs/frontend/account-risk-summary.md.Closes #975
Test plan
npm run test:run -- src/components/RiskSummaryCard.test.tsx src/components/VaultDashboard.test.tsx src/components/VaultDashboard.emptystate.test.tsx— 3 files, 26 tests, all passing