-
Notifications
You must be signed in to change notification settings - Fork 4
add property of puissance_nominale_grouped in opendata_stations.csv #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tykayn
wants to merge
3
commits into
Jungle-Bus:master
Choose a base branch
from
tykayn:tk/gh-puissance-nominale
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est vraiment une erreur d'avoir des puissances nominales différentes sur les différents points de charge d'une station ? (c'est une vraie question, désolée si c'est une question bête 😋 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Très bonne question, d'un point de vue utilisateur la valeur la plus haute est la plus pertinente car les puissances d'un point de charge ne se cumulent pas, elles sont limitées au max parmi celles disponibles et qui peut le plus peut le moins.
Donc si quelqu'un a un véhicule qui prend de la haute puissance, il pourra cibler une station dont au moins un point de charge est capable de délivrer la plus haute en priorité pour savoir où charger le moins longtemps possible. Car souvent, quand on a une puissance max importante, ça veut dire que la station est moderne et qu'on aura plus de facilités à s'y charger, et que y'aura souvent plusieurs points de charge de cette haute puissance. On pourrait aussi garder l'info de l'énumération mais ça me semble plus pertinent d'avoir seulement le max.
On pourrait tenter de faire ensuite un mapping entre les tags des sockets et ceux de la puissance nominale, mais pour faire simple je pensais plutôt ajouter une info dont je connais l'avantage utilisateur et avec un résultat moins hasardeux.
Ce serait bien si les producteurs de données faisaient les choses dans le détail et pouvaient donner clairement les puissances de chaque socket mais bon, on n'y est pas encore et le csv ne permet pas d'avoir clairement l'info. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d'ailleurs tu m'as donné une idée, on peut avoir une colonne avec la valeur de base et la valeur qui n'a que le max, comme ça les gens qui réutilisent auront le choix.