Skip to content

Fix docs saying source instead of destination #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulianSchmid merged 1 commit into from
Dec 21, 2025
Merged

Fix docs saying source instead of destination #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etherparse/src/net/ipv4_header_slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
/// It must ensured that the slice exactly contains the IPv4 header
/// and the ihl (intra header length) & total length must be consistent.
#[inline]
pub(crate) unsafe fn from_slice_unchecked(slice: &[u8]) -> Ipv4HeaderSlice {

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (macos-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (macos-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (macos-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (macos-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-beta) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-beta) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-beta) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-beta) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-32bit-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-32bit-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-32bit-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-32bit-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-msvc-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-msvc-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-msvc-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-msvc-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-nightly) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-nightly) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-nightly) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-nightly) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-gnu-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-gnu-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-gnu-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (win-gnu-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / cargo build and test (linux-stable) 

hiding a lifetime that's elided elsewhere is confusing

Check warning on line 92 in etherparse/src/net/ipv4_header_slice.rs

View workflow job for this annotation

GitHub Actions / codecoverage_test 

hiding a lifetime that's elided elsewhere is confusing
Ipv4HeaderSlice { slice }
}

Expand Down Expand Up @@ -293,7 +293,7 @@
Ipv4Addr::from(self.source())
}

/// Returns a slice containing the ipv4 source address.
/// Returns a slice containing the ipv4 destination address.
#[inline]
pub fn destination(&self) -> [u8; 4] {
// SAFETY:
Expand Down
Loading