Add Traffic class support for IPv6 #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JulianSchmid would you mind taking a look at this? I would like to use the this implementation in my application rather than my copy/pasta one that is sitting in there now. |
Owner
|
Hi @baxterjo , Sorry I currently don't have a lot of time. I will try to have a look at it in the following weeks. Greets |
JulianSchmid
force-pushed
the
baxterjo/add-traffic-class-support-ipv6
branch
from
f66a0ba to
818ad09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
========================================
Coverage 99.37% 99.37%
========================================
Files 185 187 +2
Lines 33971 34156 +185
========================================
+ Hits 33759 33944 +185
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JulianSchmid
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two repr(u8) enums for the DSCP and ECN fields that are part of the traffic class octet in IPv6 packets. With their respective readers and writers.
Added setters and getters for the two fields in the traffic class octet for the
Ipv6Headerstruct.Note: AFAIK these enums could also be used for the IPv4 ecn and dscp fields because they have the same location within their respective octets. Something to consider for ergonomics.