Repository navigation
Use NetworkOptions.ca_roots_path() for GIT_SSL_CAINFO - #73
Merged
Merged
Conversation
`git()` unconditionally set `GIT_SSL_CAINFO` to Julia's bundled `share/julia/cert.pem`, ignoring the user's CA configuration (`JULIA_SSL_CA_ROOTS_PATH`, `SSL_CERT_FILE`, `SSL_CERT_DIR`) and even an explicitly set `GIT_SSL_CAINFO`. Behind a TLS-intercepting proxy or with a corporate CA, HTTPS operations then fail with "self-signed certificate in certificate chain". Take the location from `NetworkOptions.ca_roots_path()`, as the rest of Julia (Downloads, LibGit2) does, passing a directory as `GIT_SSL_CAPATH`, and leave the environment alone when the user already set `GIT_SSL_CAINFO` or `GIT_SSL_CAPATH`. Fixes JuliaVersionControl#41. Supersedes JuliaVersionControl#47. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 94.44% 93.33% -1.12%
==========================================
Files 1 1
Lines 36 45 +9
==========================================
+ Hits 34 42 +8
- Misses 2 3 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
giordano
approved these changes
Oct 2, 2026
Contributor
Author
|
I don't have permissions on this repo, so you'll have to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git()unconditionally setGIT_SSL_CAINFOto Julia's bundledshare/julia/cert.pem, ignoring the user's CA configuration (JULIA_SSL_CA_ROOTS_PATH,SSL_CERT_FILE,SSL_CERT_DIR) and even an explicitly setGIT_SSL_CAINFO. Behind a TLS-intercepting proxy or with a corporate CA, HTTPS operations then fail with "self-signed certificate in certificate chain".Take the location from
NetworkOptions.ca_roots_path(), as the rest of Julia (Downloads, LibGit2) does, passing a directory asGIT_SSL_CAPATH, and leave the environment alone when the user already setGIT_SSL_CAINFOorGIT_SSL_CAPATH.Fixes #41. Supersedes #47.