Skip to content

Better GitHub Action workflow for JuliaFormatter #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code-style.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Code style
name: Format suggestions

on:
pull_request:
Expand All @@ -7,4 +7,4 @@ jobs:
code-style:
runs-on: ubuntu-latest
steps:
- uses: tkf/julia-code-style-suggesters@v1
- uses: julia-actions/julia-format@v2
5 changes: 3 additions & 2 deletions docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ makedocs(;
repolink = "https://github.com/JuliaTesting/Aqua.jl",
assets = ["assets/favicon.ico"],
),
authors = "Takafumi Arakaki",
authors = "Takafumi Arakaki",
)

deploydocs(; repo = "github.com/JuliaTesting/Aqua.jl", push_preview = true)
deploydocs( ; repo = "github.com/JuliaTesting/Aqua.jl", push_preview = true)

15 changes: 8 additions & 7 deletions src/unbound_args.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,18 @@ of the method.
function test_unbound_args(m::Module; broken::Bool = false)
unbounds = detect_unbound_args_recursively(m)
if !isempty(unbounds)
printstyled(
stderr,
"Unbound type parameters detected:\n";
bold = true,
color = Base.error_color(),
printstyled(
stderr,
"Unbound type parameters detected:\n";
bold = true,
color = Base.error_color(),
)
show(stderr, MIME"text/plain"(), unbounds)
show(stderr,MIME"text/plain"( ) , unbounds)
println(stderr)
end
if broken
@test_broken isempty(unbounds)
@test_broken isempty(
unbounds)
else
@test isempty(unbounds)
end
Expand Down
16 changes: 8 additions & 8 deletions test/test_unbound_args.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ include("preamble.jl")
using PkgUnboundArgs

@testset begin
results = @testtestset begin
Aqua.test_unbound_args(PkgUnboundArgs)
end
@test length(results) == 1
@test results[1] isa Test.Fail
results = @testtestset begin
Aqua.test_unbound_args(PkgUnboundArgs)
end
@test length(results) == 1
@test results[1] isa Test.Fail

# It works with other tests:
Aqua.test_ambiguities(PkgUnboundArgs)
Aqua.test_undefined_exports(PkgUnboundArgs)
# It works with other tests:
Aqua.test_ambiguities( PkgUnboundArgs )
Aqua.test_undefined_exports(PkgUnboundArgs)
end

end # module