Register some Array functions #1715
Merged
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1715 +/- ##
===========================================
- Coverage 80.10% 22.92% -57.19%
===========================================
Files 55 55
Lines 5187 5082 -105
===========================================
- Hits 4155 1165 -2990
- Misses 1032 3917 +2885 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisRackauckas
merged commit d31039d
into
JuliaSymbolics:master
10 of 19 checks passed
Member
|
This shouldn't have been merged 😅 Many tests fail |
Member
|
I reverted so that #1714 can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have symbolic manipulation of these functions in generated code, its required to have them registered. This should help with use in generating efficient code involving these methods.