Skip to content

fix: fix bugs #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 101 commits into from
Oct 20, 2025
Merged

fix: fix bugs #798

merged 101 commits into from
Oct 20, 2025

Conversation

@AayushSabharwal
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025 •
edited
Loading

Benchmark Results (Julia vlts)

Time benchmarks
master 6b6fec6... master / 6b6fec6...
arithmetic/addition 0.0957 ± 0.0011 ms 0.1 ± 0.0012 ms 0.953 ± 0.016
arithmetic/division 30.4 ± 0.89 μs 29 ± 0.67 μs 1.05 ± 0.039
arithmetic/multiplication 0.0812 ± 0.0019 ms 0.0774 ± 0.0028 ms 1.05 ± 0.045
overhead/acrule/a+2 2.69 ± 0.04 μs 3.08 ± 0.06 μs 0.876 ± 0.021
overhead/acrule/a+2+b 0.07 ± 0.01 μs 0.07 ± 0.01 μs 1 ± 0.2
overhead/acrule/a+b 4.9 ± 0.07 μs 5.69 ± 0.11 μs 0.861 ± 0.021
overhead/acrule/noop:Int 0.05 ± 0.01 μs 0.05 ± 0.009 μs 1 ± 0.27
overhead/acrule/noop:Sym 0.05 ± 0.01 μs 0.05 ± 0.01 μs 1 ± 0.28
overhead/get_degrees/large_poly 0.105 ± 0.0046 s 0.111 ± 0.0042 s 0.947 ± 0.055
overhead/rule/noop:Int 0.06 ± 0.01 μs 0.07 ± 0 μs 0.857 ± 0.14
overhead/rule/noop:Sym 0.06 ± 0.01 μs 0.07 ± 0.01 μs 0.857 ± 0.19
overhead/rule/noop:Term 0.06 ± 0.01 μs 0.07 ± 0.01 μs 0.857 ± 0.19
overhead/ruleset/noop:Int 30 ± 0 ns 30 ± 0 ns 1 ± 0
overhead/ruleset/noop:Sym 0.11 ± 0.01 μs 0.301 ± 0.001 μs 0.365 ± 0.033
overhead/ruleset/noop:Term 0.821 ± 0.019 μs 1.23 ± 0.02 μs 0.666 ± 0.019
overhead/simplify/noop:Int 30 ± 0 ns 30 ± 0 ns 1 ± 0
overhead/simplify/noop:Sym 30 ± 10 ns 30 ± 10 ns 1 ± 0.47
overhead/simplify/noop:Term 0.0328 ± 0.00065 ms 0.0371 ± 0.0012 ms 0.883 ± 0.033
overhead/simplify/randterm (+, *):serial 0.33 ± 0.0046 s 0.359 ± 0.0015 s 0.92 ± 0.013
overhead/simplify/randterm (+, *):thread 0.443 ± 0.13 s 0.525 ± 0.11 s 0.845 ± 0.31
overhead/simplify/randterm (/, *):serial 0.0858 ± 0.0017 ms 0.0938 ± 0.0024 ms 0.914 ± 0.03
overhead/simplify/randterm (/, *):thread 0.0888 ± 0.0016 ms 0.0962 ± 0.0025 ms 0.923 ± 0.03
overhead/substitute/a 0.0597 ± 0.0015 ms 0.0631 ± 0.0013 ms 0.946 ± 0.03
overhead/substitute/a,b 0.0696 ± 0.0018 ms 0.0789 ± 0.0017 ms 0.882 ± 0.03
overhead/substitute/a,b,c 0.0342 ± 0.00062 ms 0.072 ± 0.0017 ms 0.475 ± 0.014
polyform/easy_iszero 31.5 ± 0.56 μs 28.1 ± 0.5 μs 1.12 ± 0.028
polyform/isone 1.18 ± 0.022 ms 1.18 ± 0.024 ms 1 ± 0.027
polyform/isone:noop 0.15 ± 0.001 μs 0.15 ± 0.001 μs 1 ± 0.0094
polyform/iszero 1.02 ± 0.017 ms 1.01 ± 0.019 ms 1.01 ± 0.026
polyform/iszero:noop 0.151 ± 0.01 μs 0.151 ± 0.01 μs 1 ± 0.094
polyform/simplify_fractions 1.31 ± 0.023 ms 1.31 ± 0.027 ms 1 ± 0.027
time_to_load 1.24 ± 0.014 s 1.14 ± 0.0011 s 1.09 ± 0.012
Memory benchmarks
master 6b6fec6... master / 6b6fec6...
arithmetic/addition 0.538 k allocs: 21.3 kB 0.538 k allocs: 21.4 kB 0.996
arithmetic/division 0.182 k allocs: 6.44 kB 0.189 k allocs: 6.62 kB 0.973
arithmetic/multiplication 0.476 k allocs: 17.6 kB 0.453 k allocs: 17 kB 1.04
overhead/acrule/a+2 0.037 k allocs: 1.38 kB 0.039 k allocs: 1.4 kB 0.983
overhead/acrule/a+2+b 0 allocs: 0 B 0 allocs: 0 B
overhead/acrule/a+b 0.053 k allocs: 2.05 kB 0.057 k allocs: 2.09 kB 0.978
overhead/acrule/noop:Int 0 allocs: 0 B 0 allocs: 0 B
overhead/acrule/noop:Sym 0 allocs: 0 B 0 allocs: 0 B
overhead/get_degrees/large_poly 0.712 M allocs: 20.6 MB 0.712 M allocs: 20.6 MB 1
overhead/rule/noop:Int 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
overhead/rule/noop:Sym 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
overhead/rule/noop:Term 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
overhead/ruleset/noop:Int 0 allocs: 0 B 0 allocs: 0 B
overhead/ruleset/noop:Sym 3 allocs: 0.109 kB 3 allocs: 0.109 kB 1
overhead/ruleset/noop:Term 12 allocs: 0.391 kB 12 allocs: 0.391 kB 1
overhead/simplify/noop:Int 0 allocs: 0 B 0 allocs: 0 B
overhead/simplify/noop:Sym 0 allocs: 0 B 0 allocs: 0 B
overhead/simplify/noop:Term 0.33 k allocs: 12.9 kB 0.412 k allocs: 15.6 kB 0.828
overhead/simplify/randterm (+, *):serial 2.77 M allocs: 0.109 GB 3.34 M allocs: 0.126 GB 0.868
overhead/simplify/randterm (+, *):thread 2.8 M allocs: 0.267 GB 3.35 M allocs: 0.283 GB 0.943
overhead/simplify/randterm (/, *):serial 0.875 k allocs: 31.4 kB 0.889 k allocs: 31.5 kB 0.995
overhead/simplify/randterm (/, *):thread 0.9 k allocs: 0.0313 MB 0.914 k allocs: 0.0315 MB 0.995
overhead/substitute/a 0.336 k allocs: 11.7 kB 0.37 k allocs: 14.3 kB 0.818
overhead/substitute/a,b 0.388 k allocs: 13.4 kB 0.472 k allocs: 18 kB 0.74
overhead/substitute/a,b,c 0.238 k allocs: 7.03 kB 0.437 k allocs: 16.2 kB 0.435
polyform/easy_iszero 0.187 k allocs: 6.08 kB 0.172 k allocs: 6.03 kB 1.01
polyform/isone 9.19 k allocs: 0.587 MB 9.62 k allocs: 0.614 MB 0.956
polyform/isone:noop 2 allocs: 32 B 2 allocs: 32 B 1
polyform/iszero 7.9 k allocs: 0.493 MB 7.97 k allocs: 0.51 MB 0.967
polyform/iszero:noop 2 allocs: 32 B 2 allocs: 32 B 1
polyform/simplify_fractions 10 k allocs: 0.618 MB 10.8 k allocs: 0.656 MB 0.941
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025 •
edited
Loading

Benchmark Results (Julia v1)

Time benchmarks
master 6b6fec6... master / 6b6fec6...
arithmetic/addition 0.0923 ± 0.0029 ms 0.0999 ± 0.0096 ms 0.924 ± 0.093
arithmetic/division 28.5 ± 0.64 μs 28.6 ± 0.73 μs 0.997 ± 0.034
arithmetic/multiplication 0.0807 ± 0.0079 ms 0.0786 ± 0.0068 ms 1.03 ± 0.13
overhead/acrule/a+2 2.68 ± 0.1 μs 3.35 ± 0.1 μs 0.799 ± 0.038
overhead/acrule/a+2+b 0.07 ± 0.01 μs 0.07 ± 0.001 μs 1 ± 0.14
overhead/acrule/a+b 4.84 ± 0.13 μs 6.16 ± 0.17 μs 0.785 ± 0.03
overhead/acrule/noop:Int 30 ± 0 ns 30 ± 0 ns 1 ± 0
overhead/acrule/noop:Sym 0.06 ± 0.01 μs 0.06 ± 0.01 μs 1 ± 0.24
overhead/get_degrees/large_poly 0.0914 ± 0.0091 s 0.0931 ± 0.0093 s 0.982 ± 0.14
overhead/rule/noop:Int 0.06 ± 0 μs 0.06 ± 0.01 μs 1 ± 0.17
overhead/rule/noop:Sym 0.06 ± 0.001 μs 0.06 ± 0.01 μs 1 ± 0.17
overhead/rule/noop:Term 0.06 ± 0.001 μs 0.06 ± 0.01 μs 1 ± 0.17
overhead/ruleset/noop:Int 30 ± 0 ns 30 ± 0 ns 1 ± 0
overhead/ruleset/noop:Sym 0.11 ± 0 μs 0.29 ± 0.01 μs 0.379 ± 0.013
overhead/ruleset/noop:Term 0.822 ± 0.029 μs 1.24 ± 0.021 μs 0.662 ± 0.026
overhead/simplify/noop:Int 30 ± 0 ns 30 ± 0 ns 1 ± 0
overhead/simplify/noop:Sym 30 ± 10 ns 30 ± 10 ns 1 ± 0.47
overhead/simplify/noop:Term 0.0321 ± 0.00062 ms 0.0389 ± 0.00076 ms 0.824 ± 0.023
overhead/simplify/randterm (+, *):serial 0.329 ± 0.033 s 0.439 ± 0.018 s 0.751 ± 0.082
overhead/simplify/randterm (+, *):thread 0.352 ± 0.015 s 0.461 ± 0.023 s 0.763 ± 0.051
overhead/simplify/randterm (/, *):serial 0.0874 ± 0.013 ms 0.098 ± 0.015 ms 0.892 ± 0.2
overhead/simplify/randterm (/, *):thread 0.0888 ± 0.013 ms 0.0999 ± 0.015 ms 0.888 ± 0.18
overhead/substitute/a 0.0587 ± 0.0051 ms 0.0632 ± 0.0064 ms 0.93 ± 0.13
overhead/substitute/a,b 0.0682 ± 0.0056 ms 0.0795 ± 0.0093 ms 0.858 ± 0.12
overhead/substitute/a,b,c 31.1 ± 0.78 μs 0.0753 ± 0.009 ms 0.412 ± 0.05
polyform/easy_iszero 30.7 ± 0.59 μs 27.9 ± 0.54 μs 1.1 ± 0.03
polyform/isone 1.14 ± 0.022 ms 1.1 ± 0.018 ms 1.03 ± 0.026
polyform/isone:noop 0.15 ± 0.01 μs 0.15 ± 0.01 μs 1 ± 0.094
polyform/iszero 0.979 ± 0.016 ms 0.938 ± 0.015 ms 1.04 ± 0.024
polyform/iszero:noop 0.15 ± 0.001 μs 0.15 ± 0.001 μs 1 ± 0.0094
polyform/simplify_fractions 1.26 ± 0.026 ms 1.23 ± 0.023 ms 1.03 ± 0.028
time_to_load 1.41 ± 0.0082 s 1.25 ± 0.033 s 1.13 ± 0.031
Memory benchmarks
master 6b6fec6... master / 6b6fec6...
arithmetic/addition 0.538 k allocs: 21.3 kB 0.538 k allocs: 21.4 kB 0.996
arithmetic/division 0.176 k allocs: 6.22 kB 0.201 k allocs: 6.98 kB 0.891
arithmetic/multiplication 0.475 k allocs: 17.6 kB 0.452 k allocs: 17 kB 1.04
overhead/acrule/a+2 0.038 k allocs: 1.33 kB 0.04 k allocs: 1.35 kB 0.983
overhead/acrule/a+2+b 0 allocs: 0 B 0 allocs: 0 B
overhead/acrule/a+b 0.054 k allocs: 1.95 kB 0.058 k allocs: 2 kB 0.977
overhead/acrule/noop:Int 0 allocs: 0 B 0 allocs: 0 B
overhead/acrule/noop:Sym 0 allocs: 0 B 0 allocs: 0 B
overhead/get_degrees/large_poly 0.601 M allocs: 18.9 MB 0.601 M allocs: 18.9 MB 1
overhead/rule/noop:Int 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
overhead/rule/noop:Sym 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
overhead/rule/noop:Term 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
overhead/ruleset/noop:Int 0 allocs: 0 B 0 allocs: 0 B
overhead/ruleset/noop:Sym 3 allocs: 0.109 kB 3 allocs: 0.109 kB 1
overhead/ruleset/noop:Term 14 allocs: 0.422 kB 14 allocs: 0.422 kB 1
overhead/simplify/noop:Int 0 allocs: 0 B 0 allocs: 0 B
overhead/simplify/noop:Sym 0 allocs: 0 B 0 allocs: 0 B
overhead/simplify/noop:Term 0.333 k allocs: 12.3 kB 0.44 k allocs: 16.4 kB 0.75
overhead/simplify/randterm (+, *):serial 2.8 M allocs: 0.106 GB 4.99 M allocs: 0.172 GB 0.617
overhead/simplify/randterm (+, *):thread 2.85 M allocs: 0.264 GB 4.78 M allocs: 0.322 GB 0.819
overhead/simplify/randterm (/, *):serial 0.851 k allocs: 30.6 kB 0.865 k allocs: 30.8 kB 0.995
overhead/simplify/randterm (/, *):thread 0.882 k allocs: 31.5 kB 0.896 k allocs: 31.7 kB 0.995
overhead/substitute/a 0.322 k allocs: 11.4 kB 0.388 k allocs: 15 kB 0.76
overhead/substitute/a,b 0.374 k allocs: 13.1 kB 0.498 k allocs: 19 kB 0.687
overhead/substitute/a,b,c 0.222 k allocs: 6.78 kB 0.482 k allocs: 18.2 kB 0.372
polyform/easy_iszero 0.186 k allocs: 6.06 kB 0.175 k allocs: 6.25 kB 0.97
polyform/isone 12.4 k allocs: 0.607 MB 12.7 k allocs: 0.62 MB 0.98
polyform/isone:noop 2 allocs: 32 B 2 allocs: 32 B 1
polyform/iszero 9.82 k allocs: 0.5 MB 9.96 k allocs: 0.506 MB 0.989
polyform/iszero:noop 2 allocs: 32 B 2 allocs: 32 B 1
polyform/simplify_fractions 12.8 k allocs: 0.631 MB 13.5 k allocs: 0.658 MB 0.959
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@AayushSabharwal AayushSabharwal force-pushed the as/more-fixes branch 2 times, most recently from b44b0c3 to 794c0ba Compare September 29, 2025 09:52
@AayushSabharwal AayushSabharwal force-pushed the as/more-fixes branch 2 times, most recently from a169db4 to 98e8799 Compare September 30, 2025 09:00
@AayushSabharwal AayushSabharwal mentioned this pull request Oct 6, 2025
Closed
@AayushSabharwal AayushSabharwal force-pushed the as/more-fixes branch 3 times, most recently from 20f6915 to c153e4e Compare October 17, 2025 16:10
@AayushSabharwal
feat: add doc page to describe variant structure
4d35d1b
@AayushSabharwal
feat: add search_variables! for sets
8bd6aed
@AayushSabharwal
fix: handle edge cases in scalarization
83c3c09
@AayushSabharwal
fix: add missing promote_shape methods
7f2ae97
@AayushSabharwal
feat: special-case identity maper in mapreduce
40c2455
@AayushSabharwal
refactor: do not use TermInterface.head
b66c8fa
@AayushSabharwal
refactor: only allow DataType symtypes
4184e45
@AayushSabharwal
refactor: improve diadic promote_symtype to statically dispatch
90dedd5
@AayushSabharwal
refactor: improve all promote_symtype to statically dispatch
b4f60c2
@AayushSabharwal
refactor: mark some precompilation tests as broken
1e6f374
@AayushSabharwal
feat: register LinearAlgebra.norm
c51732c
@AayushSabharwal
fix: handle scalar ArrayOp
b1146db
@AayushSabharwal
refactor: only run precompilation on 1.11
2f9e372
@AayushSabharwal
refactor: improve precompile-friendliness of mul_worker
1f3e177
@AayushSabharwal
refactor: improve precompile workload
2c8cb56
@AayushSabharwal
test: improve precompilation test
24c66e5
@AayushSabharwal
test: disable precompilation test
70677a5
@AayushSabharwal AayushSabharwal merged commit 56e2685 into master Oct 20, 2025
15 of 20 checks passed
@AayushSabharwal AayushSabharwal deleted the as/more-fixes branch October 20, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AayushSabharwal