Skip to content

Conversation

@tmigot
Copy link
Member

@tmigot tmigot commented Dec 4, 2025

Related issues

Closes #181

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Copilot AI review requested due to automatic review settings December 4, 2025 12:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missing namespace qualification for the reset! function call. The issue was that reset!(stats) was being called without qualifying it as SolverCore.reset!(stats), which would cause a method resolution error since reset! is not explicitly imported from the SolverCore package.

  • Adds SolverCore. namespace qualification to the reset! call in the main solver function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tmigot tmigot merged commit 97e5aa0 into main Dec 4, 2025
10 of 14 checks passed
@tmigot tmigot deleted the fix-reset branch December 4, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UndefVarError: reset! not defined in DCISolver when updating to SolverCore 0.3.9

2 participants