Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageTransformations: Update ImageCore bounds to 0.1-0.8 #389

Closed
wants to merge 1 commit into from
Closed

ImageTransformations: Update ImageCore bounds to 0.1-0.8 #389

wants to merge 1 commit into from

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth changed the title Update ImageCore bounds to 0.1-0.8 ImageTransformations: Update ImageCore bounds to 0.1-0.8 Apr 28, 2019
@timholy
Copy link
Member

timholy commented Apr 28, 2019

As long as it's actually true, it's right. (I assume the package passes tests with ImageCore 0.8, right?) In other words, the goal here is to encode reality; the question of whether it will be sufficient to un-stick the JuliaImages ecosystem is a little separate. ImageMorphology just cropped up as a new blocker, perhaps that will be fixed by #390.

@IanButterworth IanButterworth mentioned this pull request Apr 28, 2019
Merged
8 tasks
@IanButterworth
Copy link
Member Author

You're right. I tested and it passes locally.

Also I thought it might be worth rooting this issue out across all packages that have ImageCore = 0.7... bounds over in #392.

@IanButterworth
Copy link
Member Author

Closed as covered by #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compat fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanButterworth @timholy @fredrikekre