Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unittests on master are currently failing on Windows (example), with the following unexpected pass:
this PR changes
@test_brokento@testas it seems to work now.Also, this corrects the temporary base directory in the Windows tests to use the one specified by
runner.temp, rather than that specified by%TEMP%which is whatBase.mktempdir()uses.(@stevengj this fixes the reason for the failures on #1015)