Skip to content

Expand precompilation #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 5, 2023
Merged

Expand precompilation #1015

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
198c5c2
Create expanded precompilation
MilesCranmer Nov 29, 2022
5f628db
Expand conversions for precompile
MilesCranmer Nov 29, 2022
8fdc8c9
Precompile more types
MilesCranmer Nov 30, 2022
1c8dca1
Add calls from running `runtests.jl`
MilesCranmer Dec 2, 2022
1ce1ea3
Remove overly-specific precompile statements
MilesCranmer Dec 2, 2022
08aeb43
`Core.TypeofVarargs` requires newer Julia
MilesCranmer Dec 3, 2022
dcf5988
Require Julia >= 1.4
MilesCranmer Dec 3, 2022
08f3eb1
Remove Julia 1.0 test
MilesCranmer Dec 3, 2022
ad27e94
Merge branch 'master' into precompilation
MilesCranmer Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/system.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
architecture: [x64]
python-version: ['3.x']
julia-version:
- '1.0'
- '1'
- 'nightly'
include:
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ VersionParsing = "81def892-9a0e-5fdd-b105-ffc91e053289"
Conda = "1.0"
MacroTools = "0.4, 0.5"
VersionParsing = "1.0"
julia = "0.7, 1.0"
julia = "1.4"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
12 changes: 2 additions & 10 deletions src/PyCall.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,16 +980,8 @@ include("serialize.jl")
include("pyinit.jl")

#########################################################################
# Precompilation: just an optimization to speed up initialization.
# Here, we precompile functions that are passed to cfunction by __init__,
# for the reasons described in JuliaLang/julia#12256.

precompile(pyjlwrap_call, (PyPtr,PyPtr,PyPtr))
precompile(pyjlwrap_dealloc, (PyPtr,))
precompile(pyjlwrap_repr, (PyPtr,))
precompile(pyjlwrap_hash, (PyPtr,))
precompile(pyjlwrap_hash32, (PyPtr,))

# TODO: precompilation of the io.jl functions
include("precompile.jl")

#########################################################################
end # module PyCall
Loading